demo seed change

services/production/app/api/ml_insights.py

@@ -237,9 +237,8 @@ async def trigger_yield_prediction(
                 logger.error(error_msg, exc_info=True)
                 errors.append(error_msg)
 
-        # Close orchestrator and clients
+        # Close orchestrator
         await orchestrator.close()
-        await recipes_client.close()
 
         # Build response
         response = YieldPredictionResponse(
@@ -286,3 +285,89 @@ async def ml_insights_health():
             "POST /ml/insights/predict-yields"
         ]
     }
+
+
+# ================================================================
+# INTERNAL ENDPOINTS (for demo-session service)
+# ================================================================
+
+from fastapi import Request
+
+# Create a separate router for internal endpoints to avoid the tenant prefix
+internal_router = APIRouter(
+    tags=["ML Insights - Internal"]
+)
+
+
+@internal_router.post("/api/v1/tenants/{tenant_id}/production/internal/ml/generate-yield-insights")
+async def generate_yield_insights_internal(
+    tenant_id: str,
+    request: Request,
+    db: AsyncSession = Depends(get_db)
+):
+    """
+    Internal endpoint to trigger yield insights generation for demo sessions.
+
+    This endpoint is called by the demo-session service after cloning data.
+    It uses the same ML logic as the public endpoint but with optimized defaults.
+
+    Security: Protected by X-Internal-Service header check.
+
+    Args:
+        tenant_id: The tenant UUID
+        request: FastAPI request object
+        db: Database session
+
+    Returns:
+        {
+            "insights_posted": int,
+            "tenant_id": str,
+            "status": str
+        }
+    """
+    # Verify internal service header
+    if not request or request.headers.get("X-Internal-Service") not in ["demo-session", "internal"]:
+        logger.warning("Unauthorized internal API call", tenant_id=tenant_id)
+        raise HTTPException(
+            status_code=403,
+            detail="This endpoint is for internal service use only"
+        )
+
+    logger.info("Internal yield insights generation triggered", tenant_id=tenant_id)
+
+    try:
+        # Use the existing yield prediction logic with sensible defaults
+        request_data = YieldPredictionRequest(
+            recipe_ids=None,  # Analyze all recipes
+            lookback_days=90,  # 3 months of history
+            min_history_runs=20  # Minimum 20 production runs required
+        )
+
+        # Call the existing yield prediction endpoint logic
+        result = await trigger_yield_prediction(
+            tenant_id=tenant_id,
+            request_data=request_data,
+            db=db
+        )
+
+        # Return simplified response for internal use
+        return {
+            "insights_posted": result.total_insights_posted,
+            "tenant_id": tenant_id,
+            "status": "success" if result.success else "failed",
+            "message": result.message,
+            "recipes_analyzed": result.recipes_analyzed,
+            "recipes_with_issues": result.recipes_with_issues
+        }
+
+    except Exception as e:
+        logger.error(
+            "Internal yield insights generation failed",
+            tenant_id=tenant_id,
+            error=str(e),
+            exc_info=True
+        )
+        raise HTTPException(
+            status_code=500,
+            detail=f"Internal yield insights generation failed: {str(e)}"
+        )