REFACTOR data service

shared/clients/__init__.py

@@ -6,7 +6,8 @@ Provides easy access to all service clients
 
 from .base_service_client import BaseServiceClient, ServiceAuthenticator
 from .training_client import TrainingServiceClient
-from .data_client import DataServiceClient
+from .sales_client import SalesServiceClient
+from .external_client import ExternalServiceClient
 from .forecast_client import ForecastServiceClient
 
 # Import config
@@ -25,14 +26,24 @@ def get_training_client(config: BaseServiceSettings = None, service_name: str =
         _client_cache[cache_key] = TrainingServiceClient(config, service_name)
     return _client_cache[cache_key]
 
-def get_data_client(config: BaseServiceSettings = None, service_name: str = "unknown") -> DataServiceClient:
-    """Get or create a data service client"""
+def get_sales_client(config: BaseServiceSettings = None, service_name: str = "unknown") -> SalesServiceClient:
+    """Get or create a sales service client"""
     if config is None:
         from app.core.config import settings as config
     
-    cache_key = f"data_{service_name}"
+    cache_key = f"sales_{service_name}"
     if cache_key not in _client_cache:
-        _client_cache[cache_key] = DataServiceClient(config, service_name)
+        _client_cache[cache_key] = SalesServiceClient(config, service_name)
+    return _client_cache[cache_key]
+
+def get_external_client(config: BaseServiceSettings = None, service_name: str = "unknown") -> ExternalServiceClient:
+    """Get or create an external service client"""
+    if config is None:
+        from app.core.config import settings as config
+    
+    cache_key = f"external_{service_name}"
+    if cache_key not in _client_cache:
+        _client_cache[cache_key] = ExternalServiceClient(config, service_name)
     return _client_cache[cache_key]
 
 def get_forecast_client(config: BaseServiceSettings = None, service_name: str = "unknown") -> ForecastServiceClient:
@@ -45,6 +56,7 @@ def get_forecast_client(config: BaseServiceSettings = None, service_name: str =
         _client_cache[cache_key] = ForecastServiceClient(config, service_name)
     return _client_cache[cache_key]
 
+
 class ServiceClients:
     """Convenient wrapper for all service clients"""
     
@@ -54,7 +66,8 @@ class ServiceClients:
         
         # Initialize clients lazily
         self._training_client = None
-        self._data_client = None
+        self._sales_client = None
+        self._external_client = None
         self._forecast_client = None
     
     def _get_default_config(self):
@@ -73,11 +86,18 @@ class ServiceClients:
         return self._training_client
     
     @property
-    def data(self) -> DataServiceClient:
-        """Get data service client"""
-        if self._data_client is None:
-            self._data_client = get_data_client(self.config, self.service_name)
-        return self._data_client
+    def sales(self) -> SalesServiceClient:
+        """Get sales service client"""
+        if self._sales_client is None:
+            self._sales_client = get_sales_client(self.config, self.service_name)
+        return self._sales_client
+    
+    @property
+    def external(self) -> ExternalServiceClient:
+        """Get external service client"""
+        if self._external_client is None:
+            self._external_client = get_external_client(self.config, self.service_name)
+        return self._external_client
     
     @property
     def forecast(self) -> ForecastServiceClient:
@@ -96,11 +116,13 @@ __all__ = [
     'BaseServiceClient',
     'ServiceAuthenticator', 
     'TrainingServiceClient',
-    'DataServiceClient',
+    'SalesServiceClient',
+    'ExternalServiceClient',
     'ForecastServiceClient',
     'ServiceClients',
     'get_training_client',
-    'get_data_client', 
+    'get_sales_client',
+    'get_external_client', 
     'get_forecast_client',
     'get_service_clients'
 ]