REFACTOR API gateway

2025-07-26 18:46:52 +02:00
parent e49893e10a
commit e4885db828
24 changed files with 1049 additions and 1080 deletions
--- a/services/data/app/api/sales.py
+++ b/services/data/app/api/sales.py
@@ -1,13 +1,13 @@
 # ================================================================
-# services/data/app/api/sales.py - UPDATED WITH UNIFIED AUTH
+# services/data/app/api/sales.py - FIXED FOR NEW TENANT-SCOPED ARCHITECTURE
 # ================================================================
-"""Sales data API endpoints with unified authentication"""
+"""Sales data API endpoints with tenant-scoped URLs"""

-from fastapi import APIRouter, Depends, HTTPException, UploadFile, File, Form, Query, Response
+from fastapi import APIRouter, Depends, HTTPException, UploadFile, File, Form, Query, Response, Path
 from fastapi.responses import StreamingResponse
 from sqlalchemy.ext.asyncio import AsyncSession
 from typing import List, Optional, Dict, Any
-import uuid
+from uuid import UUID
 from datetime import datetime
 import base64
 import structlog
@@ -31,22 +31,23 @@ from app.services.messaging import (
 )

 # Import unified authentication from shared library
-from shared.auth.decorators import (
-    get_current_user_dep,
-    get_current_tenant_id_dep
-)
+from shared.auth.decorators import get_current_user_dep

 router = APIRouter(tags=["sales"])
 logger = structlog.get_logger()

-@router.post("/", response_model=SalesDataResponse)
+# ================================================================
+# TENANT-SCOPED SALES ENDPOINTS
+# ================================================================
+
+@router.post("/tenants/{tenant_id}/sales", response_model=SalesDataResponse)
 async def create_sales_record(
    sales_data: SalesDataCreate,
-    tenant_id: str = Depends(get_current_tenant_id_dep),
+    tenant_id: UUID = Path(..., description="Tenant ID"),
    current_user: Dict[str, Any] = Depends(get_current_user_dep),
    db: AsyncSession = Depends(get_db)
 ):
-    """Create a new sales record"""
+    """Create a new sales record for tenant"""
    try:
        logger.debug("Creating sales record", 
                    product=sales_data.product_name, 
@@ -54,7 +55,7 @@ async def create_sales_record(
                    tenant_id=tenant_id,
                    user_id=current_user["user_id"])
        
-        # Override tenant_id from token/header
+        # Override tenant_id from URL path (gateway already verified access)
        sales_data.tenant_id = tenant_id
        
        record = await SalesService.create_sales_record(sales_data, db)
@@ -85,14 +86,14 @@ async def create_sales_record(
                    tenant_id=tenant_id)
        raise HTTPException(status_code=500, detail=f"Failed to create sales record: {str(e)}")

-@router.post("/bulk", response_model=List[SalesDataResponse])
+@router.post("/tenants/{tenant_id}/sales/bulk", response_model=List[SalesDataResponse])
 async def create_bulk_sales(
    sales_data: List[SalesDataCreate],
-    tenant_id: str = Depends(get_current_tenant_id_dep),
+    tenant_id: UUID = Path(..., description="Tenant ID"),
    current_user: Dict[str, Any] = Depends(get_current_user_dep),
    db: AsyncSession = Depends(get_db)
 ):
-    """Create multiple sales records"""
+    """Create multiple sales records for tenant"""
    try:
        logger.debug("Creating bulk sales records", 
                    count=len(sales_data),
@@ -127,16 +128,16 @@ async def create_bulk_sales(
                    tenant_id=tenant_id)
        raise HTTPException(status_code=500, detail=f"Failed to create bulk sales records: {str(e)}")

-@router.get("/", response_model=List[SalesDataResponse])
+@router.get("/tenants/{tenant_id}/sales", response_model=List[SalesDataResponse])
 async def get_sales_data(
-    start_date: Optional[datetime] = Query(None),
-    end_date: Optional[datetime] = Query(None),
-    product_name: Optional[str] = Query(None),
-    tenant_id: str = Depends(get_current_tenant_id_dep),
+    tenant_id: UUID = Path(..., description="Tenant ID"),
+    start_date: Optional[datetime] = Query(None, description="Start date filter"),
+    end_date: Optional[datetime] = Query(None, description="End date filter"),
+    product_name: Optional[str] = Query(None, description="Product name filter"),
    current_user: Dict[str, Any] = Depends(get_current_user_dep),
    db: AsyncSession = Depends(get_db)
 ):
-    """Get sales data with filters"""
+    """Get sales data for tenant with filters"""
    try:
        logger.debug("Querying sales data", 
                    tenant_id=tenant_id,
@@ -164,15 +165,15 @@ async def get_sales_data(
                    tenant_id=tenant_id)
        raise HTTPException(status_code=500, detail=f"Failed to query sales data: {str(e)}")

-@router.post("/import", response_model=SalesImportResult)
+@router.post("/tenants/{tenant_id}/sales/import", response_model=SalesImportResult)
 async def import_sales_data(
+    tenant_id: UUID = Path(..., description="Tenant ID"),
    file: UploadFile = File(...),
    file_format: str = Form(...),
-    tenant_id: str = Depends(get_current_tenant_id_dep),
    current_user: Dict[str, Any] = Depends(get_current_user_dep),
    db: AsyncSession = Depends(get_db)
 ):
-    """Import sales data from file"""
+    """Import sales data from file for tenant"""
    try:
        logger.info("Importing sales data", 
                   tenant_id=tenant_id,
@@ -220,26 +221,27 @@ async def import_sales_data(
                    tenant_id=tenant_id)
        raise HTTPException(status_code=500, detail=f"Failed to import sales data: {str(e)}")

-@router.post("/import/validate", response_model=SalesValidationResult)
+@router.post("/tenants/{tenant_id}/sales/import/validate", response_model=SalesValidationResult)
 async def validate_import_data(
    import_data: SalesDataImport,
-    tenant_id: str = Depends(get_current_tenant_id_dep),
+    tenant_id: UUID = Path(..., description="Tenant ID"),
    current_user: Dict[str, Any] = Depends(get_current_user_dep)
 ):
-    """Validate import data before processing"""
+    """Validate import data - Gateway already verified tenant access"""
    try:
-        logger.debug("Validating import data", tenant_id=tenant_id)
+        logger.debug("Validating import data", 
+                    tenant_id=tenant_id,
+                    user_id=current_user["user_id"])
        
-        # Override tenant_id
+        # Set tenant context from URL path
        import_data.tenant_id = tenant_id
        
-        validation = await DataImportService.validate_import_data(
-            import_data.model_dump()
-        )
+        validation = await DataImportService.validate_import_data(import_data.model_dump())
        
        logger.debug("Validation completed", 
                    is_valid=validation.get("is_valid", False),
                    tenant_id=tenant_id)
+        
        return validation
        
    except Exception as e:
@@ -248,15 +250,17 @@ async def validate_import_data(
                    tenant_id=tenant_id)
        raise HTTPException(status_code=500, detail=f"Failed to validate import data: {str(e)}")

-@router.get("/import/template/{format_type}")
+@router.get("/tenants/{tenant_id}/sales/import/template/{format_type}")
 async def get_import_template(
-    format_type: str,
+    tenant_id: UUID = Path(..., description="Tenant ID"),
+    format_type: str = Path(..., description="Template format: csv, json, excel"),
    current_user: Dict[str, Any] = Depends(get_current_user_dep)
 ):
    """Get import template for specified format"""
    try:
        logger.debug("Getting import template", 
                    format=format_type,
+                    tenant_id=tenant_id,
                    user_id=current_user["user_id"])
        
        template = await DataImportService.get_import_template(format_type)
@@ -265,7 +269,9 @@ async def get_import_template(
            logger.warning("Template generation error", error=template["error"])
            raise HTTPException(status_code=400, detail=template["error"])
        
-        logger.debug("Template generated successfully", format=format_type)
+        logger.debug("Template generated successfully", 
+                    format=format_type,
+                    tenant_id=tenant_id)
        
        if format_type.lower() == "csv":
            return Response(
@@ -291,14 +297,16 @@ async def get_import_template(
    except HTTPException:
        raise
    except Exception as e:
-        logger.error("Failed to generate import template", error=str(e))
+        logger.error("Failed to generate import template", 
+                    error=str(e),
+                    tenant_id=tenant_id)
        raise HTTPException(status_code=500, detail=f"Failed to generate template: {str(e)}")

-@router.get("/analytics")
+@router.get("/tenants/{tenant_id}/sales/analytics")
 async def get_sales_analytics(
+    tenant_id: UUID = Path(..., description="Tenant ID"),
    start_date: Optional[datetime] = Query(None, description="Start date"),
    end_date: Optional[datetime] = Query(None, description="End date"),
-    tenant_id: str = Depends(get_current_tenant_id_dep),
    current_user: Dict[str, Any] = Depends(get_current_user_dep),
    db: AsyncSession = Depends(get_db)
 ):
@@ -322,17 +330,17 @@ async def get_sales_analytics(
                    tenant_id=tenant_id)
        raise HTTPException(status_code=500, detail=f"Failed to generate analytics: {str(e)}")

-@router.post("/export")
+@router.post("/tenants/{tenant_id}/sales/export")
 async def export_sales_data(
+    tenant_id: UUID = Path(..., description="Tenant ID"),
    export_format: str = Query("csv", description="Export format: csv, excel, json"),
    start_date: Optional[datetime] = Query(None, description="Start date"),
    end_date: Optional[datetime] = Query(None, description="End date"),
    products: Optional[List[str]] = Query(None, description="Filter by products"),
-    tenant_id: str = Depends(get_current_tenant_id_dep),
    current_user: Dict[str, Any] = Depends(get_current_user_dep),
    db: AsyncSession = Depends(get_db)
 ):
-    """Export sales data in specified format"""
+    """Export sales data in specified format for tenant"""
    try:
        logger.info("Exporting sales data", 
                   tenant_id=tenant_id,
@@ -376,14 +384,14 @@ async def export_sales_data(
                    tenant_id=tenant_id)
        raise HTTPException(status_code=500, detail=f"Failed to export sales data: {str(e)}")

-@router.delete("/{record_id}")
+@router.delete("/tenants/{tenant_id}/sales/{record_id}")
 async def delete_sales_record(
-    record_id: str,
-    tenant_id: str = Depends(get_current_tenant_id_dep),
+    tenant_id: UUID = Path(..., description="Tenant ID"),
+    record_id: str = Path(..., description="Sales record ID"),
    current_user: Dict[str, Any] = Depends(get_current_user_dep),
    db: AsyncSession = Depends(get_db)
 ):
-    """Delete a sales record"""
+    """Delete a sales record for tenant"""
    try:
        logger.info("Deleting sales record", 
                   record_id=record_id,
@@ -413,14 +421,14 @@ async def delete_sales_record(
                    tenant_id=tenant_id)
        raise HTTPException(status_code=500, detail=f"Failed to delete sales record: {str(e)}")

-@router.get("/summary")
+@router.get("/tenants/{tenant_id}/sales/summary")
 async def get_sales_summary(
+    tenant_id: UUID = Path(..., description="Tenant ID"),
    period: str = Query("daily", description="Summary period: daily, weekly, monthly"),
-    tenant_id: str = Depends(get_current_tenant_id_dep),
    current_user: Dict[str, Any] = Depends(get_current_user_dep),
    db: AsyncSession = Depends(get_db)
 ):
-    """Get sales summary for specified period"""
+    """Get sales summary for specified period for tenant"""
    try:
        logger.debug("Getting sales summary", 
                    tenant_id=tenant_id,
@@ -437,13 +445,13 @@ async def get_sales_summary(
                    tenant_id=tenant_id)
        raise HTTPException(status_code=500, detail=f"Failed to generate summary: {str(e)}")

-@router.get("/products")
+@router.get("/tenants/{tenant_id}/sales/products")
 async def get_products_list(
-    tenant_id: str = Depends(get_current_tenant_id_dep),
+    tenant_id: UUID = Path(..., description="Tenant ID"),
    current_user: Dict[str, Any] = Depends(get_current_user_dep),
    db: AsyncSession = Depends(get_db)
 ):
-    """Get list of all products with sales data"""
+    """Get list of all products with sales data for tenant"""
    try:
        logger.debug("Getting products list", tenant_id=tenant_id)
        
@@ -458,4 +466,78 @@ async def get_products_list(
        logger.error("Failed to get products list", 
                    error=str(e),
                    tenant_id=tenant_id)
-        raise HTTPException(status_code=500, detail=f"Failed to get products list: {str(e)}")
+        raise HTTPException(status_code=500, detail=f"Failed to get products list: {str(e)}")
+
+@router.get("/tenants/{tenant_id}/sales/{record_id}", response_model=SalesDataResponse)
+async def get_sales_record(
+    tenant_id: UUID = Path(..., description="Tenant ID"),
+    record_id: str = Path(..., description="Sales record ID"),
+    current_user: Dict[str, Any] = Depends(get_current_user_dep),
+    db: AsyncSession = Depends(get_db)
+):
+    """Get a specific sales record for tenant"""
+    try:
+        logger.debug("Getting sales record", 
+                    record_id=record_id,
+                    tenant_id=tenant_id)
+        
+        record = await SalesService.get_sales_record(record_id, db)
+        
+        if not record or record.tenant_id != tenant_id:
+            raise HTTPException(status_code=404, detail="Sales record not found")
+        
+        logger.debug("Sales record retrieved", 
+                    record_id=record_id,
+                    tenant_id=tenant_id)
+        return record
+        
+    except HTTPException:
+        raise
+    except Exception as e:
+        logger.error("Failed to get sales record", 
+                    error=str(e),
+                    tenant_id=tenant_id,
+                    record_id=record_id)
+        raise HTTPException(status_code=500, detail=f"Failed to get sales record: {str(e)}")
+
+@router.put("/tenants/{tenant_id}/sales/{record_id}", response_model=SalesDataResponse)
+async def update_sales_record(
+    sales_data: SalesDataCreate,
+    record_id: str = Path(..., description="Sales record ID"),
+    tenant_id: UUID = Path(..., description="Tenant ID"),
+    current_user: Dict[str, Any] = Depends(get_current_user_dep),
+    db: AsyncSession = Depends(get_db)
+):
+    """Update a sales record for tenant"""
+    try:
+        logger.info("Updating sales record", 
+                   record_id=record_id,
+                   tenant_id=tenant_id,
+                   user_id=current_user["user_id"])
+        
+        # Verify record exists and belongs to tenant
+        existing_record = await SalesService.get_sales_record(record_id, db)
+        if not existing_record or existing_record.tenant_id != tenant_id:
+            raise HTTPException(status_code=404, detail="Sales record not found")
+        
+        # Override tenant_id from URL path
+        sales_data.tenant_id = tenant_id
+        
+        updated_record = await SalesService.update_sales_record(record_id, sales_data, db)
+        
+        if not updated_record:
+            raise HTTPException(status_code=404, detail="Sales record not found")
+        
+        logger.info("Sales record updated successfully", 
+                   record_id=record_id,
+                   tenant_id=tenant_id)
+        return updated_record
+        
+    except HTTPException:
+        raise
+    except Exception as e:
+        logger.error("Failed to update sales record", 
+                    error=str(e),
+                    tenant_id=tenant_id,
+                    record_id=record_id)
+        raise HTTPException(status_code=500, detail=f"Failed to update sales record: {str(e)}")