Start fixing forecast service API 13

services/forecasting/app/services/forecasting_service.py

@@ -63,6 +63,7 @@ class ForecastingService:
             # Generate prediction using ML service
             prediction_result = await self.prediction_service.predict(
                 model_id=model_info["model_id"],
+                model_path=model_info["model_path"],
                 features=features,
                 confidence_level=request.confidence_level
             )
@@ -268,7 +269,7 @@ class ForecastingService:
         }
         
         # Add Spanish holidays
-        features["is_holiday"] = await self._is_spanish_holiday(request.forecast_date)
+        features["is_holiday"] = self._is_spanish_holiday(request.forecast_date)
         
    
         weather_data = await self._get_weather_forecast(tenant_id, 1)
@@ -276,26 +277,26 @@ class ForecastingService:
         
         return features
     
-    async def _is_spanish_holiday(self, forecast_date: date) -> bool:
-        """Check if date is a Spanish holiday"""
+    def _is_spanish_holiday(self, date: datetime) -> bool:
+        """Check if a date is a major Spanish holiday"""
+        month_day = (date.month, date.day)
         
-        try:
-            # Call data service for holiday information
-            async with httpx.AsyncClient() as client:
-                response = await client.get(
-                    f"{settings.DATA_SERVICE_URL}/api/v1/holidays/check",
-                    params={"date": forecast_date.isoformat()},
-                    headers={"X-Service-Auth": settings.SERVICE_AUTH_TOKEN}
-                )
-                
-                if response.status_code == 200:
-                    return response.json().get("is_holiday", False)
-                else:
-                    return False
-                    
-        except Exception as e:
-            logger.warning("Error checking holiday status", error=str(e))
-            return False
+        # Major Spanish holidays that affect bakery sales
+        spanish_holidays = [
+            (1, 1),   # New Year
+            (1, 6),   # Epiphany (Reyes)
+            (5, 1),   # Labour Day
+            (8, 15),  # Assumption
+            (10, 12), # National Day
+            (11, 1),  # All Saints
+            (12, 6),  # Constitution
+            (12, 8),  # Immaculate Conception
+            (12, 25), # Christmas
+            (5, 15),  # San Isidro (Madrid patron saint)
+            (5, 2),   # Madrid Community Day
+        ]
+        
+        return month_day in spanish_holidays
     
     async def _get_weather_forecast(self, tenant_id: str, days: str) -> Dict[str, Any]:
         """Get weather forecast for the date"""