Add role-based filtering and imporve code

services/forecasting/app/api/analytics.py

@@ -12,6 +12,7 @@ from app.services.prediction_service import PredictionService
 from shared.database.base import create_database_manager
 from app.core.config import settings
 from shared.routing import RouteBuilder
+from shared.auth.access_control import analytics_tier_required
 
 route_builder = RouteBuilder('forecasting')
 logger = structlog.get_logger()
@@ -27,13 +28,14 @@ def get_enhanced_prediction_service():
 @router.get(
     route_builder.build_analytics_route("predictions-performance")
 )
+@analytics_tier_required
 async def get_predictions_performance(
     tenant_id: str = Path(..., description="Tenant ID"),
     start_date: Optional[date] = Query(None),
     end_date: Optional[date] = Query(None),
     prediction_service: PredictionService = Depends(get_enhanced_prediction_service)
 ):
-    """Get predictions performance analytics"""
+    """Get predictions performance analytics (Professional+ tier required)"""
     try:
         logger.info("Getting predictions performance", tenant_id=tenant_id)