New alert service

services/external/app/main.py

@@ -7,7 +7,8 @@ from fastapi import FastAPI
 from sqlalchemy import text
 from app.core.config import settings
 from app.core.database import database_manager
-from app.services.messaging import setup_messaging, cleanup_messaging
+# Removed import of non-existent messaging module
+# External service will use unified messaging from base class
 from shared.service_base import StandardFastAPIService
 from shared.redis_utils import initialize_redis, close_redis
 # Include routers
@@ -139,13 +140,15 @@ class ExternalService(StandardFastAPIService):
         )
 
     async def _setup_messaging(self):
-        """Setup messaging for external service"""
-        await setup_messaging()
-        self.logger.info("External service messaging initialized")
+        """Setup messaging for external service using unified messaging"""
+        # The base class will handle the unified messaging setup
+        # For external service, no additional setup is needed
+        self.logger.info("External service unified messaging initialized")
 
     async def _cleanup_messaging(self):
         """Cleanup messaging for external service"""
-        await cleanup_messaging()
+        # The base class will handle the unified messaging cleanup
+        self.logger.info("External service unified messaging cleaned up")
 
     async def on_startup(self, app: FastAPI):
         """Custom startup logic for external service"""

services/external/app/services/messaging.py

@@ -1,63 +0,0 @@
-# services/external/app/services/messaging.py
-"""
-External Service Messaging - Event Publishing using shared messaging infrastructure
-"""
-
-from shared.messaging.rabbitmq import RabbitMQClient
-from app.core.config import settings
-import structlog
-
-logger = structlog.get_logger()
-
-# Single global instance
-data_publisher = RabbitMQClient(settings.RABBITMQ_URL, "data-service")
-
-async def setup_messaging():
-    """Initialize messaging for data service"""
-    try:
-        success = await data_publisher.connect()
-        if success:
-            logger.info("Data service messaging initialized")
-        else:
-            logger.warning("Data service messaging failed to initialize")
-        return success
-    except Exception as e:
-        logger.warning("Failed to setup messaging", error=str(e))
-        return False
-
-async def cleanup_messaging():
-    """Cleanup messaging for data service"""
-    try:
-        await data_publisher.disconnect()
-        logger.info("Data service messaging cleaned up")
-    except Exception as e:
-        logger.warning("Error during messaging cleanup", error=str(e))
-
-async def publish_weather_updated(data: dict) -> bool:
-    """Publish weather updated event"""
-    try:
-        return await data_publisher.publish_data_event("weather.updated", data)
-    except Exception as e:
-        logger.warning("Failed to publish weather updated event", error=str(e))
-        return False
-
-async def publish_traffic_updated(data: dict) -> bool:
-    """Publish traffic updated event"""
-    try:
-        return await data_publisher.publish_data_event("traffic.updated", data)
-    except Exception as e:
-        logger.warning("Failed to publish traffic updated event", error=str(e))
-        return False
-
-
-
-# Health check for messaging
-async def check_messaging_health() -> dict:
-    """Check messaging system health"""
-    try:
-        if data_publisher.connected:
-            return {"status": "healthy", "service": "rabbitmq", "connected": True}
-        else:
-            return {"status": "unhealthy", "service": "rabbitmq", "connected": False, "error": "Not connected"}
-    except Exception as e:
-        return {"status": "unhealthy", "service": "rabbitmq", "connected": False, "error": str(e)}