Improve the frontend and fix TODOs

2025-10-24 13:05:04 +02:00
parent 07c33fa578
commit 61376b7a9f
100 changed files with 8284 additions and 3419 deletions
--- a/services/inventory/app/api/stock_entries.py
+++ b/services/inventory/app/api/stock_entries.py
@@ -100,6 +100,106 @@ async def get_stock(
        )


+# ===== STOCK MOVEMENTS ROUTES (must come before stock/{stock_id} route) =====
+
+@router.get(
+    route_builder.build_base_route("stock/movements"),
+    response_model=List[StockMovementResponse]
+)
+async def get_stock_movements(
+    tenant_id: UUID = Path(..., description="Tenant ID"),
+    skip: int = Query(0, ge=0, description="Number of records to skip"),
+    limit: int = Query(100, ge=1, le=1000, description="Number of records to return"),
+    ingredient_id: Optional[str] = Query(None, description="Filter by ingredient"),
+    movement_type: Optional[str] = Query(None, description="Filter by movement type"),
+    current_user: dict = Depends(get_current_user_dep),
+    db: AsyncSession = Depends(get_db)
+):
+    """Get stock movements with filtering"""
+    logger.info("Stock movements endpoint called",
+               tenant_id=str(tenant_id),
+               ingredient_id=ingredient_id,
+               skip=skip,
+               limit=limit,
+               movement_type=movement_type)
+
+    # Validate and convert ingredient_id if provided
+    ingredient_uuid = None
+    if ingredient_id:
+        try:
+            ingredient_uuid = UUID(ingredient_id)
+            logger.info("Ingredient ID validated", ingredient_id=str(ingredient_uuid))
+        except (ValueError, AttributeError) as e:
+            logger.error("Invalid ingredient_id format",
+                        ingredient_id=ingredient_id,
+                        error=str(e))
+            raise HTTPException(
+                status_code=status.HTTP_400_BAD_REQUEST,
+                detail=f"Invalid ingredient_id format: {ingredient_id}. Must be a valid UUID."
+            )
+
+    try:
+        service = InventoryService()
+        movements = await service.get_stock_movements(
+            tenant_id, skip, limit, ingredient_uuid, movement_type
+        )
+        logger.info("Successfully retrieved stock movements",
+                   count=len(movements),
+                   tenant_id=str(tenant_id))
+        return movements
+    except ValueError as e:
+        logger.error("Validation error in stock movements",
+                    error=str(e),
+                    tenant_id=str(tenant_id),
+                    ingredient_id=ingredient_id)
+        raise HTTPException(
+            status_code=status.HTTP_400_BAD_REQUEST,
+            detail=str(e)
+        )
+    except Exception as e:
+        logger.error("Failed to get stock movements",
+                    error=str(e),
+                    error_type=type(e).__name__,
+                    tenant_id=str(tenant_id),
+                    ingredient_id=ingredient_id)
+        raise HTTPException(
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            detail=f"Failed to get stock movements: {str(e)}"
+        )
+
+
+@router.post(
+    route_builder.build_base_route("stock/movements"),
+    response_model=StockMovementResponse,
+    status_code=status.HTTP_201_CREATED
+)
+@require_user_role(['admin', 'owner', 'member'])
+async def create_stock_movement(
+    movement_data: StockMovementCreate,
+    tenant_id: UUID = Path(..., description="Tenant ID"),
+    current_user: dict = Depends(get_current_user_dep),
+    db: AsyncSession = Depends(get_db)
+):
+    """Create stock movement record"""
+    try:
+        user_id = get_current_user_id(current_user)
+        service = InventoryService()
+        movement = await service.create_stock_movement(movement_data, tenant_id, user_id)
+        return movement
+    except ValueError as e:
+        raise HTTPException(
+            status_code=status.HTTP_400_BAD_REQUEST,
+            detail=str(e)
+        )
+    except Exception as e:
+        raise HTTPException(
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            detail="Failed to create stock movement"
+        )
+
+
+# ===== STOCK DETAIL ROUTES (must come after stock/movements routes) =====
+
@router.get(
    route_builder.build_resource_detail_route("stock", "stock_id"),
    response_model=StockResponse
@@ -199,68 +299,3 @@ async def delete_stock(
            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
            detail="Failed to delete stock entry"
        )
-
-
-@router.get(
-    route_builder.build_base_route("stock/movements"),
-    response_model=List[StockMovementResponse]
-)
-async def get_stock_movements(
-    tenant_id: UUID = Path(..., description="Tenant ID"),
-    skip: int = Query(0, ge=0, description="Number of records to skip"),
-    limit: int = Query(100, ge=1, le=1000, description="Number of records to return"),
-    ingredient_id: Optional[UUID] = Query(None, description="Filter by ingredient"),
-    movement_type: Optional[str] = Query(None, description="Filter by movement type"),
-    current_user: dict = Depends(get_current_user_dep),
-    db: AsyncSession = Depends(get_db)
-):
-    """Get stock movements with filtering"""
-    logger.info("API endpoint reached!",
-               tenant_id=tenant_id,
-               ingredient_id=ingredient_id,
-               skip=skip,
-               limit=limit)
-
-    try:
-        service = InventoryService()
-        movements = await service.get_stock_movements(
-            tenant_id, skip, limit, ingredient_id, movement_type
-        )
-        logger.info("Returning movements", count=len(movements))
-        return movements
-    except Exception as e:
-        logger.error("Failed to get stock movements", error=str(e), tenant_id=tenant_id)
-        raise HTTPException(
-            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail="Failed to get stock movements"
-        )
-
-
-@router.post(
-    route_builder.build_base_route("stock/movements"),
-    response_model=StockMovementResponse,
-    status_code=status.HTTP_201_CREATED
-)
-@require_user_role(['admin', 'owner', 'member'])
-async def create_stock_movement(
-    movement_data: StockMovementCreate,
-    tenant_id: UUID = Path(..., description="Tenant ID"),
-    current_user: dict = Depends(get_current_user_dep),
-    db: AsyncSession = Depends(get_db)
-):
-    """Create stock movement record"""
-    try:
-        user_id = get_current_user_id(current_user)
-        service = InventoryService()
-        movement = await service.create_stock_movement(movement_data, tenant_id, user_id)
-        return movement
-    except ValueError as e:
-        raise HTTPException(
-            status_code=status.HTTP_400_BAD_REQUEST,
-            detail=str(e)
-        )
-    except Exception as e:
-        raise HTTPException(
-            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail="Failed to create stock movement"
-        )