Improve AI logic

frontend/src/components/domain/forecasting/ModelDetailsModal.tsx

@@ -9,6 +9,8 @@ interface ModelDetailsModalProps {
   isOpen: boolean;
   onClose: () => void;
   model: TrainedModelResponse;
+  onRetrain?: (settings: any) => void;
+  onViewPredictions?: (modelId: string) => void;
 }
 
 // Helper function to determine performance color based on accuracy
@@ -89,7 +91,9 @@ const FeatureTag: React.FC<{ feature: string }> = ({ feature }) => {
 const ModelDetailsModal: React.FC<ModelDetailsModalProps> = ({ 
   isOpen, 
   onClose, 
-  model 
+  model,
+  onRetrain,
+  onViewPredictions
 }) => {
   // Early return if model is not provided
   if (!model) {
@@ -173,7 +177,9 @@ const ModelDetailsModal: React.FC<ModelDetailsModalProps> = ({
         },
         {
           label: "Período de Entrenamiento",
-          value: `${formatDate((model as any).training_start_date || model.training_period?.start_date || new Date().toISOString())} - ${formatDate((model as any).training_end_date || model.training_period?.end_date || new Date().toISOString())}`
+          value: model.data_period_start && model.data_period_end 
+            ? `${formatDate(model.data_period_start)} a ${formatDate(model.data_period_end)}`
+            : 'Datos no disponibles'
         }
       ]
     },
@@ -307,7 +313,9 @@ const ModelDetailsModal: React.FC<ModelDetailsModalProps> = ({
         },
         {
           label: "Período de Entrenamiento",
-          value: `${formatDate((model as any).training_start_date || model.training_period?.start_date || new Date().toISOString())} a ${formatDate((model as any).training_end_date || model.training_period?.end_date || new Date().toISOString())}`,
+          value: model.data_period_start && model.data_period_end 
+            ? `${formatDate(model.data_period_start)} a ${formatDate(model.data_period_end)}`
+            : 'Datos no disponibles',
           span: 2
         }
       ]
@@ -360,16 +368,27 @@ const ModelDetailsModal: React.FC<ModelDetailsModalProps> = ({
       label: 'Actualizar Modelo',
       variant: 'primary' as const,
       onClick: () => {
-        // TODO: Implement model retraining functionality
-        // This should trigger a new training job for the product
+        // Implement model retraining functionality
+        // This triggers a new training job for the product using the existing API
+        if (onRetrain && model?.inventory_product_id) {
+          onRetrain({
+            seasonality_mode: 'additive',
+            daily_seasonality: true,
+            weekly_seasonality: true,
+            yearly_seasonality: false,
+          });
+        }
       }
     },
     {
       label: 'Ver Predicciones',
       variant: 'secondary' as const,
       onClick: () => {
-        // TODO: Navigate to forecast history or predictions view
-        // This should show historical predictions vs actual sales
+        // Navigate to forecast history or predictions view
+        // This shows historical predictions vs actual sales
+        if (onViewPredictions && model?.model_id) {
+          onViewPredictions(model.model_id);
+        }
       }
     }
   ];
@@ -401,4 +420,4 @@ const ModelDetailsModal: React.FC<ModelDetailsModalProps> = ({
   );
 };
 
-export default ModelDetailsModal;
+export default ModelDetailsModal;

frontend/src/components/domain/forecasting/RetrainModelModal.tsx

@@ -330,8 +330,8 @@ export const RetrainModelModal: React.FC<RetrainModelModalProps> = ({
     }
   };
 
-  // Define tab-style actions for header navigation - memoized
-  const actions: EditViewModalAction[] = React.useMemo(() => [
+  // Header navigation actions (tabs)
+  const headerActions = React.useMemo(() => [
     {
       label: t('models:retrain.modes.quick', 'Rápido'),
       icon: Zap,
@@ -358,8 +358,11 @@ export const RetrainModelModal: React.FC<RetrainModelModalProps> = ({
   return (
     <EditViewModal
       isOpen={isOpen}
-      onClose={onClose}
-      mode="edit"
+      onClose={() => {
+        setMode('quick');
+        onClose();
+      }}
+      mode="edit" // Keep in edit mode so it shows Cancel/Save
       title={t('models:retrain.title', 'Reentrenar Modelo')}
       subtitle={ingredient.name}
       statusIndicator={{
@@ -371,9 +374,10 @@ export const RetrainModelModal: React.FC<RetrainModelModalProps> = ({
       }}
       size="lg"
       sections={sections}
-      actions={actions}
+      actions={headerActions}
       actionsPosition="header"
-      showDefaultActions={true}
+      showDefaultActions={true} // Enable default actions (Cancel/Save)
+      saveLabel={t('models:retrain.start', 'Iniciar Reentrenamiento')} // Custom save button label for retraining
       onSave={handleRetrain}
       onFieldChange={handleFieldChange}
       loading={isLoading}

frontend/src/components/domain/onboarding/steps/UploadSalesDataStep.tsx

@@ -272,6 +272,7 @@ export const UploadSalesDataStep: React.FC<UploadSalesDataStepProps> = ({
 
         const ingredientData = {
           name: item.suggested_name,
+          product_type: item.product_type,
           category: item.category,
           unit_of_measure: item.unit_of_measure,
           low_stock_threshold: minimumStock,