Improve the frontend and repository layer

services/pos/app/api/pos_operations.py

@@ -14,6 +14,8 @@ from app.core.database import get_db
 from shared.auth.decorators import get_current_user_dep
 from shared.auth.access_control import require_user_role, admin_role_required
 from shared.routing import RouteBuilder
+from app.services.pos_transaction_service import POSTransactionService
+from app.services.pos_config_service import POSConfigurationService
 
 router = APIRouter()
 logger = structlog.get_logger()
@@ -74,15 +76,33 @@ async def get_sync_status(
 ):
     """Get synchronization status and recent sync history"""
     try:
+        transaction_service = POSTransactionService()
+
+        # Get sync metrics from transaction service
+        sync_metrics = await transaction_service.get_sync_metrics(tenant_id)
+
+        # Get last successful sync time
+        sync_status = sync_metrics["sync_status"]
+        last_successful_sync = sync_status.get("last_sync_at")
+
+        # Calculate sync success rate
+        total = sync_metrics["total_transactions"]
+        synced = sync_status.get("synced", 0)
+        success_rate = (synced / total * 100) if total > 0 else 100.0
+
         return {
             "current_sync": None,
-            "last_successful_sync": None,
-            "recent_syncs": [],
+            "last_successful_sync": last_successful_sync.isoformat() if last_successful_sync else None,
+            "recent_syncs": [],  # Could be enhanced with actual sync history
             "sync_health": {
-                "status": "healthy",
-                "success_rate": 95.5,
-                "average_duration_minutes": 3.2,
-                "last_error": None
+                "status": "healthy" if success_rate > 90 else "degraded" if success_rate > 70 else "unhealthy",
+                "success_rate": round(success_rate, 2),
+                "average_duration_minutes": 3.2,  # Placeholder - could calculate from actual data
+                "last_error": None,
+                "total_transactions": total,
+                "synced_count": synced,
+                "pending_count": sync_status.get("pending", 0),
+                "failed_count": sync_status.get("failed", 0)
             }
         }
     except Exception as e:
@@ -159,12 +179,35 @@ async def test_pos_connection(
 ):
     """Test connection to POS system (Admin/Owner only)"""
     try:
+        config_service = POSConfigurationService()
+
+        # Get the configuration to verify it exists
+        configurations = await config_service.get_configurations_by_tenant(
+            tenant_id=tenant_id,
+            skip=0,
+            limit=100
+        )
+
+        config = next((c for c in configurations if str(c.id) == str(config_id)), None)
+
+        if not config:
+            raise HTTPException(status_code=404, detail="Configuration not found")
+
+        # For demo purposes, we assume connection is successful if config exists
+        # In production, this would actually test the POS API connection
+        is_connected = config.is_connected and config.is_active
+
         return {
-            "status": "success",
-            "message": "Connection test successful",
+            "success": is_connected,
+            "status": "success" if is_connected else "failed",
+            "message": f"Connection test {'successful' if is_connected else 'failed'} for {config.pos_system}",
             "tested_at": datetime.utcnow().isoformat(),
-            "config_id": str(config_id)
+            "config_id": str(config_id),
+            "pos_system": config.pos_system,
+            "health_status": config.health_status
         }
+    except HTTPException:
+        raise
     except Exception as e:
         logger.error("Failed to test POS connection", error=str(e),
                     tenant_id=tenant_id, config_id=config_id)